[
https://issues.apache.org/jira/browse/AVRO-3256?focusedWorklogId=685448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685448
]
ASF GitHub Bot logged work on AVRO-3256:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 18:22
Start Date: 23/Nov/21 18:22
Worklog Time Spent: 10m
Work Description: opwvhk commented on a change in pull request #1407:
URL: https://github.com/apache/avro/pull/1407#discussion_r755399216
##########
File path: doc/src/content/xdocs/idl.xml
##########
@@ -429,50 +429,62 @@ record MyRecord {
<p>Some annotations like those listed above are handled
specially. All other annotations are added as properties to
the protocol, message, schema or field.</p>
+ <p>Note that for named types, annotations should be added to
+ the type definition; they cannot be added to the type references.</p>
</section>
</section>
<section id="example">
<title>Complete Example</title>
- <p>The following is a complete example of a Avro IDL file that shows
most of the above features:</p>
+ <p>The following is an example of an Avro IDL file that shows most of
the above features:</p>
<source>
+/*
+* Header with license information.
+*/
+
/**
* An example protocol in Avro IDL
*/
@namespace("org.apache.avro.test")
protocol Simple {
-
+ /** Documentation for the enum type Kind */
Review comment:
The parser supports doc comments, but only trims them; any * prefixes on
lines are kept.
I intend to improve upon this in a PR that'll also ignore doc comments
halfway declarations. But I need PR #1377 for this, as I want the tools to emit
warnings when this happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685448)
Time Spent: 1h 20m (was: 1h 10m)
> IDL: annotations on type references change the referenced type
> --------------------------------------------------------------
>
> Key: AVRO-3256
> URL: https://issues.apache.org/jira/browse/AVRO-3256
> Project: Apache Avro
> Issue Type: Bug
> Components: java, spec, tools
> Affects Versions: 1.11.0
> Reporter: Oscar Westra van Holthe - Kind
> Assignee: Oscar Westra van Holthe - Kind
> Priority: Major
> Labels: javacc, pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The IDL compiler allows annotations on type references, and applies them on
> the referenced type.
> As can be seen in the test output file {{simple.avpr}}, the type {{MD5}} has
> the property {{"foo"="bar"}}.
> But in the input file {{simple.avdl}}:
> * The type definition in lines 39-40 has no such property
> * Line 53 adds the property to the type for the field {{hash}},
> * But it's also silently added to the type for the field {{nullableHash}} in
> line 55
> Solution: do not accept annotations for type references.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
