[
https://issues.apache.org/jira/browse/AVRO-3285?focusedWorklogId=708286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708286
]
ASF GitHub Bot logged work on AVRO-3285:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 13:27
Start Date: 13/Jan/22 13:27
Worklog Time Spent: 10m
Work Description: opwvhk commented on a change in pull request #1447:
URL: https://github.com/apache/avro/pull/1447#discussion_r783955387
##########
File path:
lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj
##########
@@ -1589,7 +1568,7 @@ Schema PrimitiveType():
| "time_ms" { return
LogicalTypes.timeMillis().addToSchema(Schema.create(Type.INT)); }
| "timestamp_ms" { return
LogicalTypes.timestampMillis().addToSchema(Schema.create(Type.LONG)); }
| "local_timestamp_ms" { return
LogicalTypes.localTimestampMillis().addToSchema(Schema.create(Type.LONG)); }
-| "decimal" { return DecimalTypeProperties(); }
+| "decimal" s = DecimalTypeProperties() { return s; }
Review comment:
Nothing directly, but the rule DecimalTypeProperties no longer shows up
as 'unused in IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708286)
Time Spent: 1h 40m (was: 1.5h)
> Upgrade JavaCC and plugin
> -------------------------
>
> Key: AVRO-3285
> URL: https://issues.apache.org/jira/browse/AVRO-3285
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.10.2
> Reporter: Oscar Westra van Holthe - Kind
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
