[
https://issues.apache.org/jira/browse/AVRO-3248?focusedWorklogId=711181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711181
]
ASF GitHub Bot logged work on AVRO-3248:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/22 09:03
Start Date: 19/Jan/22 09:03
Worklog Time Spent: 10m
Work Description: martin-g commented on a change in pull request #1396:
URL: https://github.com/apache/avro/pull/1396#discussion_r787504710
##########
File path: lang/rust/src/types.rs
##########
@@ -168,7 +173,11 @@ where
T: Into<Self>,
{
fn from(value: Option<T>) -> Self {
- Self::Union(Box::new(value.map_or_else(|| Self::Null, Into::into)))
+ // NOTE: this is incorrect in case first type in union is not "none"
Review comment:
Ignore this comment! I misunderstood it the first time!
It looks OK to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 711181)
Time Spent: 1h 50m (was: 1h 40m)
> Rust: Support named types in UnionSchema
> ----------------------------------------
>
> Key: AVRO-3248
> URL: https://issues.apache.org/jira/browse/AVRO-3248
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Lu Litao
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> currently there's no support for named type in avro's Union type in rust.
> as stated in this comment of the UnionSchma struct
> {quote}// Used to ensure uniqueness of schema inputs, and provide constant
> time finding of the
> // schema index given a value.
> // **NOTE** that this approach does not work for named types, and will have
> to be modified
> // to support that. A simple solution is to also keep a mapping of the names
> used.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
