[
https://issues.apache.org/jira/browse/AVRO-3084?focusedWorklogId=713756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713756
]
ASF GitHub Bot logged work on AVRO-3084:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/22 13:50
Start Date: 24/Jan/22 13:50
Worklog Time Spent: 10m
Work Description: martin-g commented on pull request #1143:
URL: https://github.com/apache/avro/pull/1143#issuecomment-1020120924
```
avro/lang/js on branch-1.11 [$?] is 📦 v1.11.1-SNAPSHOT via ⬢ v12.18.3 on
☁️ eu-central-1
❯ ./build.sh interop-data-test
> [email protected] interop-data-test
/home/martin/git/apache/avro/lang/js
> mocha test/interop_data_test.js
interop
Skipped: java.avro
Skipped: java_bzip2.avro
Skipped: java_deflate.avro
Skipped: java_snappy.avro
Skipped: java_xz.avro
Skipped: java_zstandard.avro
Reading js.avro
Reading js_deflate.avro
Reading perl.avro
Skipped: perl_bzip2.avro
Reading perl_deflate.avro
Skipped: perl_zstandard.avro
Reading py.avro
Skipped: py_bzip2.avro
Reading py_deflate.avro
Reading rust.avro
Skipped: rust_bzip2.avro
Reading rust_deflate.avro
Skipped: rust_snappy.avro
Skipped: rust_xz.avro
Skipped: rust_zstandard.avro
Skipped: rust_zstd.avro
```
```
ll ../../build/interop/data/
.rw-rw-r-- martin martin 36 KB Mon Jan 24 15:44:52 2022 java.avro
.rw-rw-r-- martin martin 28 KB Mon Jan 24 15:44:52 2022 java_bzip2.avro
.rw-rw-r-- martin martin 30 KB Mon Jan 24 15:44:52 2022 java_deflate.avro
.rw-rw-r-- martin martin 35 KB Mon Jan 24 15:44:52 2022 java_snappy.avro
.rw-rw-r-- martin martin 28 KB Mon Jan 24 15:44:52 2022 java_xz.avro
.rw-rw-r-- martin martin 30 KB Mon Jan 24 15:44:52 2022
java_zstandard.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 js.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 js_deflate.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl_bzip2.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl_deflate.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022
perl_zstandard.avro
.rw-rw-r-- martin martin 1.4 KB Mon Jan 24 15:44:52 2022 py.avro
.rw-rw-r-- martin martin 1.4 KB Mon Jan 24 15:44:52 2022 py_bzip2.avro
.rw-rw-r-- martin martin 1.3 KB Mon Jan 24 15:44:52 2022 py_deflate.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_bzip2.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_deflate.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_snappy.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_xz.avro
.rw-rw-r-- martin martin 1.1 KB Wed Jan 19 12:07:00 2022
rust_zstandard.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_zstd.avro
```
It seems JS supports only the `null` and `deflate` codecs. Python supports
the same two + `bzip2`, so it should be OK!
If more codecs are added later to JS we will need to use another module for
interop that supports all of them, e.g. Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 713756)
Time Spent: 40m (was: 0.5h)
> Fix JavaScript interop test to read files generated by other languages on CI
> ----------------------------------------------------------------------------
>
> Key: AVRO-3084
> URL: https://issues.apache.org/jira/browse/AVRO-3084
> Project: Apache Avro
> Issue Type: Improvement
> Components: build, interop, javascript
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [We're using the Java bindings' output for the JavaScript interop
> test|https://github.com/apache/avro/blob/master/.github/workflows/test-lang-js.yml#L100-L102]
> but [it's entirely
> skipped|https://github.com/apache/avro/runs/2133176993?check_suite_focus=true#step:10:18],
> because [JS interop test doesn't read files generated by Java and Ruby due
> to the limitation of its
> implementation|https://github.com/apache/avro/blob/master/lang/js/test/interop_data_test.js#L39-L43].
> We should use another language than Java for that purpose.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
