[
https://issues.apache.org/jira/browse/AVRO-3322?focusedWorklogId=716380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716380
]
ASF GitHub Bot logged work on AVRO-3322:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/22 12:02
Start Date: 27/Jan/22 12:02
Worklog Time Spent: 10m
Work Description: martin-g commented on pull request #1473:
URL: https://github.com/apache/avro/pull/1473#issuecomment-1023136215
If there is a chance to move to ESM then indeed there is no point in adding
more code now.
On Thu, Jan 27, 2022, 10:43 ruleeeer ***@***.***> wrote:
> Also, is my testing still necessary? (At least so far I haven't found any
> problems with it except for Buffer is not defined) because ESM's testing
> method may be very different from browserify
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/avro/pull/1473#issuecomment-1022974258>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AABYUQUN3NGKV3Z2KZQJBZTUYEATPANCNFSM5MXP7F3Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 716380)
Time Spent: 2h 50m (was: 2h 40m)
> Buffer is not defined in browser environment
> --------------------------------------------
>
> Key: AVRO-3322
> URL: https://issues.apache.org/jira/browse/AVRO-3322
> Project: Apache Avro
> Issue Type: Bug
> Components: js
> Environment: Firefox 96 & Brave 1.34(based on chromium)
> Reporter: ruleeeer
> Priority: Blocker
> Labels: pull-request-available
> Attachments: image-2022-01-25-15-57-43-468.png
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When I use avro in my browser, I find that I get the `Buffer is undefined
> error`
> !image-2022-01-25-15-57-43-468.png!
> The code I use is simple, it comes from the github repository readme.md
> {code:javascript}
> var avro = require('avro-js');
> var type = avro.parse({
> name: 'Pet',
> type: 'record',
> fields: [
> {name: 'kind', type: {name: 'Kind', type: 'enum', symbols: ['CAT',
> 'DOG']}},
> {name: 'name', type: 'string'}
> ]
> });
> var pet = {kind: 'CAT', name: 'Albert'};
> var buf = type.toBuffer(pet); // Serialized object.
> var obj = type.fromBuffer(buf); // {kind: 'CAT', name: 'Albert'}
> {code}
> Later I traced the source code and found that Buffer is used directly in
> `/etc/browser/avro.js` and `/lib/schema.js`, which is not a problem in the
> node environment because the Buffer object is mounted globally, but it is a
> problem in the browser environment because using buffer polyfill will not
> mount the Buffer object globally, You need to declare `var Buffer =
> require('buffer').Buffer` manually, so that it can be used in the browser
> environment without affecting the node environment, which also gets its
> Buffer from require('buffer').
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
