[
https://issues.apache.org/jira/browse/AVRO-3327?focusedWorklogId=717694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717694
]
ASF GitHub Bot logged work on AVRO-3327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/22 20:22
Start Date: 30/Jan/22 20:22
Worklog Time Spent: 10m
Work Description: martin-g merged pull request #1478:
URL: https://github.com/apache/avro/pull/1478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717694)
Time Spent: 20m (was: 10m)
> Use Pattern Matching to avoid is check followed by cast
> -------------------------------------------------------
>
> Key: AVRO-3327
> URL: https://issues.apache.org/jira/browse/AVRO-3327
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> return (obj is AvroDecimal) && Equals((AvroDecimal)obj); {code}
> In the current code we are checking obj to see if it is in fact an
> AvroDecimal, then we cast it for the next check (technically creating a new
> variable in memory). Since we have already validated it's value type there
> is no need to cast it.
> Suggested Change:
> {code:java}
> return (obj is AvroDecimal @decimal) && Equals(@decimal); {code}
>
> Pattern Matching Overview: [Pattern matching overview - C# guide | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/functional/pattern-matching]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
