[
https://issues.apache.org/jira/browse/AVRO-3334?focusedWorklogId=718582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718582
]
ASF GitHub Bot logged work on AVRO-3334:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 11:31
Start Date: 01/Feb/22 11:31
Worklog Time Spent: 10m
Work Description: martin-g merged pull request #1484:
URL: https://github.com/apache/avro/pull/1484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718582)
Time Spent: 50m (was: 40m)
> Simplify getNullableType in CodeGen
> -----------------------------------
>
> Key: AVRO-3334
> URL: https://issues.apache.org/jira/browse/AVRO-3334
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> First issue: C# naming for methods uses Pascal casing. Update
> getNullableType to GetNullableType. I do not see a reason to preserve
> anything from the Java library with this naming style. Additionally, the
> java library does not have this method.
> Second issue: This is a publicly exposed method it has no specific error
> handling on the input (UnionSchema schema). It should be evaluated for null
> and throw an ArgumentNullException, if null, before being used.
> Third issue: We should evaluate the null return scenarios first.
> The first validation is that the schema has 2 elements.
> The second evaluation is to determine if all of the elements (Schema.Tag) is
> not of type null.
> If these evaluations are not met the existing logic will return the schema
> where the Schema.Tag is not Schema.Type.Null
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
