[
https://issues.apache.org/jira/browse/AVRO-3347?focusedWorklogId=718972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718972
]
ASF GitHub Bot logged work on AVRO-3347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 20:53
Start Date: 01/Feb/22 20:53
Worklog Time Spent: 10m
Work Description: martin-g commented on a change in pull request #1497:
URL: https://github.com/apache/avro/pull/1497#discussion_r797008933
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -148,6 +145,20 @@ protected virtual CodeNamespace addNamespace(string name)
return ns;
}
+ /// <summary>
+ /// Adds a namespace object for the given name into the dictionary if
it doesn't exist yet.
+ /// </summary>
+ /// <param name="name">name of namespace.</param>
+ /// <returns>
+ /// Code Namespace.
+ /// </returns>
+ /// <exception cref="System.ArgumentNullException">name - name cannot
be null.</exception>
+ [Obsolete("Use AddNamespace. This call will be deprecated in a future
release.")]
Review comment:
Please see https://github.com/apache/avro/pull/1484#discussion_r796496760
I am not native English speaker, so I might be wrong !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718972)
Time Spent: 20m (was: 10m)
> Update AddNamespace in CodeGen to meet styling guidelines
> ---------------------------------------------------------
>
> Key: AVRO-3347
> URL: https://issues.apache.org/jira/browse/AVRO-3347
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current method is addNameSpace which will reference the new named method
> AddNamespace. Additionally, variables (CodeNameSpace, string) can be inlined
> to the if statement.
>
> addNameSpace should be marked obsolete and flagged for deprecation in a
> future release.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
