[
https://issues.apache.org/jira/browse/AVRO-3384?focusedWorklogId=727032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-727032
]
ASF GitHub Bot logged work on AVRO-3384:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/22 14:01
Start Date: 15/Feb/22 14:01
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040309725
There are 2k+ warnings and messages caused by Intellisense (~~30 different
compiler codes). IMO the next step in this ticket should be:
1. Identify which message codes should be ignored and which should be fixed
2. Identify the compiler messages which should be turned on (currently off)
if any
3. Prioritize the compiler message codes selected in #1 and #2. Complexity,
risk of breaking change, potential performance, better documentation,
readablity and some others should be the factors when deciding about the
priorities.
Discussing the items in #1 IMO is important, because a balance has to be
found between having a mature codebase, personal preferences and best practices.
Since there are potentially a lot of code changes, a good initial strategy
should be defined how the changes (PRs) are made (e.g. to ensure the review
process is as easy as possible)
I dont think any of these changes are a amust have in any of the upcoming
releases (unless some bugs are discovered during the changes and code reviews).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 727032)
Time Spent: 5h 50m (was: 5h 40m)
> Define C# Coding Style Guidelines
> ---------------------------------
>
> Key: AVRO-3384
> URL: https://issues.apache.org/jira/browse/AVRO-3384
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Document in a markdown file the styling guidelines to adhere to. Discussion
> of changes to happen in the Pull Request.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
