[
https://issues.apache.org/jira/browse/AVRO-3407?focusedWorklogId=729647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729647
]
ASF GitHub Bot logged work on AVRO-3407:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 13:09
Start Date: 18/Feb/22 13:09
Worklog Time Spent: 10m
Work Description: martin-g commented on a change in pull request #1552:
URL: https://github.com/apache/avro/pull/1552#discussion_r809983937
##########
File path: lang/py/avro/test/test_datafile_interop.py
##########
@@ -37,11 +37,16 @@ def test_interop(self) -> None:
for filename in _INTEROP_DATA_DIR.iterdir():
self.assertGreater(os.stat(filename).st_size, 0)
base_ext = filename.stem.split("_", 1)
- if len(base_ext) < 2 or base_ext[1] not in
avro.codecs.KNOWN_CODECS:
+ if len(base_ext) > 1 and base_ext[1] not in
avro.codecs.KNOWN_CODECS:
Review comment:
Until the Python interop tests were skipping the `null` codec files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729647)
Time Spent: 20m (was: 10m)
> Test for user metadata in the interop tests
> -------------------------------------------
>
> Key: AVRO-3407
> URL: https://issues.apache.org/jira/browse/AVRO-3407
> Project: Apache Avro
> Issue Type: Improvement
> Components: java, perl, python, rust
> Affects Versions: 1.11.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With AVRO-3405 I've added read/write APIs for user metadata to the Rust SDK
> and few basic interop tests for it.
> With this ticket I am going to unify the test for Rust, Perl, Java and Python
> SDKs.
> JavaScript SDK does not have APIs for the user metadata.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
