[ 
https://issues.apache.org/jira/browse/AVRO-3424?focusedWorklogId=733671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733671
 ]

ASF GitHub Bot logged work on AVRO-3424:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Feb/22 00:14
            Start Date: 28/Feb/22 00:14
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover commented on pull request #1571:
URL: https://github.com/apache/avro/pull/1571#issuecomment-1053734997


   That's exactly why I wanted to have this conversation.  Extension methods 
aside I wanted a centralized place to put this functionality for reuse.  And it 
looks like you are in favor of strict parsing, ie the switch statement.
   
   I think in this case you are correct because it extends string over really 
being able to extend the enum. 
   
   I will call out though that any time I hear the word util or helper, I 
really question if it should be an extension method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 733671)
    Time Spent: 1.5h  (was: 1h 20m)

> C# parsing strings into Schema.Type enum
> ----------------------------------------
>
>                 Key: AVRO-3424
>                 URL: https://issues.apache.org/jira/browse/AVRO-3424
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>            Reporter: Kyle Schoonover
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Right now this just revolves around the PrimitiveSchema NewInstance method, 
> but this would create an extension method for parsing a string into a 
> Schema.Type enum.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to