jklamer opened a new pull request #1582: URL: https://github.com/apache/avro/pull/1582
The fix in the branch this PR is based on introduces a fix that breaks other functionality. By correctly replacing fulling defined schemas with `Schema::Ref`s it exposed a bug in the resolve flow where the resolve does not recursive add in Schemas to the named_schemas map as it finds them. This leads to unresolved schema errors where the ref looks up the name from the map that has not been updated. Fixed via recursively passing the map through the flow and using Name as the key. ### Jira My pr adds to the Branch working to reolve https://issues.apache.org/jira/browse/AVRO-3433 - [ ] My PR helps address the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR" - https://issues.apache.org/jira/browse/AVRO-XXX - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests Tests added that are broken on the base branch without the changes ### Documentation No new functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
