[
https://issues.apache.org/jira/browse/AVRO-3427?focusedWorklogId=737471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737471
]
ASF GitHub Bot logged work on AVRO-3427:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/22 12:28
Start Date: 07/Mar/22 12:28
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1578:
URL: https://github.com/apache/avro/pull/1578#issuecomment-1060636467
Looks ok, however it is always hard to say so when there are no unit tests.
It is not @kordos fault, simply we just dont have coverage for avrogen. I have
#1571, which test coverage for avrogen, however it must be reviewed, since
there is some code shuffling there. Latr today I will for just testing add this
feature to my local branch and validate with unit testing, just to be sure this
change has no no unknown side effect. So merging this is not blocked by #1571.
I am not sure how I feel about the name itself. My first reaction to the
name if I would see it for the first time is, that the actual namespace to the
classes are flattened as well, not just the directory structure. (Maybe
`-flatten-directories`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737471)
Time Spent: 3h 10m (was: 3h)
> Add command line option to skip creation of directories based on namespace
> path
> -------------------------------------------------------------------------------
>
> Key: AVRO-3427
> URL: https://issues.apache.org/jira/browse/AVRO-3427
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Paweł Kordowski
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> In java each part of the namespace is a separate directory but that's not the
> case for C#.
> In C# you can have directory name that have many namespaces in it.
> For example:
> {noformat}
> Application.Manager.Api{noformat}
> can be a single directory name. In Java it would be 3 separate directories
> and because of that classes are generated under wrong path. it is placed in:
> {noformat}
> /Application/Manager/Api/{noformat}
> but it should be placed like here:
> {noformat}
> /Application.Manager.Api/{noformat}
> I think the best solution would be to add command line option that would skip
> creation of directories based on namespace and it would just create classes
> directly in pointed directory.
>
> Regards,
> Pawel
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
