[
https://issues.apache.org/jira/browse/AVRO-3433?focusedWorklogId=737890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737890
]
ASF GitHub Bot logged work on AVRO-3433:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/22 01:11
Start Date: 08/Mar/22 01:11
Worklog Time Spent: 10m
Work Description: jklamer commented on pull request #1582:
URL: https://github.com/apache/avro/pull/1582#issuecomment-1061303830
@martin-g Added the tests as I believe they are intended. On the encoding
side I believe the Values must be Union Values in line with the write schema in
this case. When I first made these tests incorrectly I came across something I
believe we will still need to address. Namely the case where a NamedSchema
defined within the Union Variant Record Schema would not get indexed in the
map. The solution to this I believe is the same as the proposed flow change
both I and @travisbrown had proposed, and I would like to push forward with
that ASAP as the fix. These changes stand alone in improving but are incomplete
against the spec.
@travisbrown any thoughts on what I proposed
[here](https://github.com/apache/avro/pull/1582#issuecomment-1060137762).
Especially naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737890)
Time Spent: 4h 50m (was: 4h 40m)
> Rust: The canonical form should preserve schema references
> ----------------------------------------------------------
>
> Key: AVRO-3433
> URL: https://issues.apache.org/jira/browse/AVRO-3433
> Project: Apache Avro
> Issue Type: Bug
> Components: rust
> Affects Versions: 1.12.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Reported at
> [https://github.com/flavray/avro-rs/issues/182#issuecomment-1059762821]
> =================================
> There still seems to be an issue with {{can't refine}} errors, at least in
> some non-recursive cases. Take the following example:
> {code:java}
> fn main() {
> let schema = r#"
> {
> "name": "test.test",
> "type": "record",
> "fields": [
> {
> "name": "bar",
> "type": { "name": "test.foo", "type": "record", "fields": [{
> "name": "id", "type": "long" }] }
> },
> { "name": "baz", "type": "test.foo" }
> ]
> }
> "#;
> let schema = apache_avro::schema::Schema::parse_str(&schema).unwrap();
> println!("{}", serde_json::to_string(&schema).unwrap());
> } {code}
> This prints the following (the same thing happens if the {{test.foo}}
> definition is in a separate file):
> {code:java}
> $ target/release/avro-test | jq
> {
> "type": "record",
> "name": "test.test",
> "fields": [
> {
> "name": "bar",
> "type": {
> "type": "record",
> "name": "test.foo",
> "fields": [
> {
> "name": "id",
> "type": "long"
> }
> ]
> }
> },
> {
> "name": "baz",
> "type": {
> "type": "record",
> "name": "test.foo",
> "fields": [
> {
> "name": "id",
> "type": "long"
> }
> ]
> }
> }
> ]
> } {code}
> Which will cause the Java tooling to fail with the
> {{org.apache.avro.SchemaParseException: Can't redefine: test}} error above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
