opwvhk opened a new pull request #1588: URL: https://github.com/apache/avro/pull/1588
Added a shared ANTLR grammar, without actions or predicates. This guarantees ANTLR can create usable parsers in any language it supports. The Java code creating a parse tree and transforming it into an IdlFile is the code to be ported to add IDL support to other languages. The IDL reader using the ANTLR generated parser replaces the JavaCC parser in the maven plugin and in the tools. The JavaCC parser has been deprecated, but not removed. Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR" - https://issues.apache.org/jira/browse/AVRO-3403 - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [X] My PR adds quite a few ~the following~ unit tests ~__OR__ does not need testing for this extremely good reason~: see PR ### Commits - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [X] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
