[
https://issues.apache.org/jira/browse/AVRO-3446?focusedWorklogId=739261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739261
]
ASF GitHub Bot logged work on AVRO-3446:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/22 03:27
Start Date: 10/Mar/22 03:27
Worklog Time Spent: 10m
Work Description: zcsizmadia edited a comment on pull request #1595:
URL: https://github.com/apache/avro/pull/1595#issuecomment-1063570501
@martin-g @RyanSkraba We have some work in progress and PR done for avrogen.
This PR makes very minimal (non-functional) changes to avrogen, however it adds
a good amount of testing for the code generation. IMO this could be a very
solid base line testing before we make any changes to avrogen. This changes
should mofify or add new unit tests. This way we have more confidence in the
changes. I had a pending PR #1574 which had these unit tests, however I think
it is a better sequencing if we add the baseline testing first to reflect and
test the current avrogen status.
The tests include the following:
1. Command line sanity checks /w return codes
2. Compiling avro schemas into cs files AND compiling them with the runtime
Roslyn compiler (DOM cannot be used in dotnet core). That old commented out
code is revived by using the roslyn compiler,
3. Checking the generated cs files directory hierarchy
4. Checking the types included in the dynamically compiled assembly
5. Instantiate object for the the types included in the dynamically compiled
assembly
6. Because of this I added a unit test
`GenerateSchemaWithNamespaceMapping_Bug_AVRO_2883` which validates that the
https://issues.apache.org/jira/browse/AVRO-2883 bug is valid, since the
compilation will fail. As soon as it is fixed with #1574 that unit test can be
removed since it will fail, becuase the issue is fixed
7. Namespace mapping for single objects, where the above bug is not a concern
8. Namespace mapping with reserved keywords in the namespace
If you agree we can prioritize this PR so, e.g. #1578 can add unit tests to
validate the new skipped directory structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 739261)
Remaining Estimate: 71.5h (was: 71h 40m)
Time Spent: 0.5h (was: 20m)
> Add avrogen unit tests
> ----------------------
>
> Key: AVRO-3446
> URL: https://issues.apache.org/jira/browse/AVRO-3446
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Labels: pull-request-available
> Original Estimate: 72h
> Time Spent: 0.5h
> Remaining Estimate: 71.5h
>
> Currently there is no unit test coverage for C# avrogen tool. It makes hard
> to add new features to it without having a trusted unit test environment.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
