[
https://issues.apache.org/jira/browse/AVRO-2211?focusedWorklogId=741914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741914
]
ASF GitHub Bot logged work on AVRO-2211:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/22 21:57
Start Date: 15/Mar/22 21:57
Worklog Time Spent: 10m
Work Description: yanivru commented on a change in pull request #1597:
URL: https://github.com/apache/avro/pull/1597#discussion_r827449126
##########
File path: lang/csharp/src/apache/main/Schema/Field.cs
##########
@@ -105,6 +105,29 @@ public enum SortOrder
/// </summary>
internal static JTokenEqualityComparer JtokenEqual = new
JTokenEqualityComparer();
+ /// <summary>
+ /// Initializes a new instance of the <see cref="Field"/> class.
+ /// </summary>
+ /// <param name="schema">schema for the field type.</param>
+ /// <param name="name">name of the field.</param>
+ /// <param name="aliases">list of aliases for the name of the
field.</param>
+ /// <param name="pos">position of the field.</param>
+ /// <param name="doc">documentation for the field.</param>
+ /// <param name="defaultValue">field's default value if it
exists.</param>
+ /// <param name="sortorder">sort order of the field.</param>
+ /// <param name="customProperties">dictionary that provides access to
custom properties.</param>
+ public Field(Schema schema,
Review comment:
I wanted to add default values to non mandatory parameters. I had to
change their order (switch between aliases and pos), and didn't want to make a
breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 741914)
Time Spent: 1h (was: 50m)
> SchemaBuilder equivalent or other means of schema creation
> ----------------------------------------------------------
>
> Key: AVRO-2211
> URL: https://issues.apache.org/jira/browse/AVRO-2211
> Project: Apache Avro
> Issue Type: Wish
> Components: csharp
> Reporter: Dan Stelljes
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, the only way to create a schema is via the Schema.Parse method.
> We'd like to be able to build a schema programmatically—would it be possible
> to (1) introduce an analogue to the SchemaBuilder from the Java library or
> (2) expose constructors on Schema and its descendants?
> Would be more than happy to contribute work on this given some direction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
