[
https://issues.apache.org/jira/browse/AVRO-3448?focusedWorklogId=742940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742940
]
ASF GitHub Bot logged work on AVRO-3448:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/22 03:37
Start Date: 17/Mar/22 03:37
Worklog Time Spent: 10m
Work Description: jklamer commented on pull request #1602:
URL: https://github.com/apache/avro/pull/1602#issuecomment-1070235112
Hey! Pushed some changes to remove the panics from the encode flow plus
refactored the naming to match the other modules. Found some other future work
that is relevant and related but in the interest avoiding scope creep I want to
get some buy-in before I proceed.
Things that can be added to this PR that are significant:
- Value Resolution flow has the same schema lookup strategy as the
encoding, decoding, and parsing flows, which means it has the same potential
namespacing issues. The flow can be changed to match the others. Better finding
this now rather than later 🙃
- Add in encoded size to the Ok() return from encode. This was discussed but
would be a lot of code change not related to the original encoding panic bug
that led to this PR.
I also added in more future work and breaking change (slight) to the PR's
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 742940)
Time Spent: 2h 50m (was: 2h 40m)
> Rust: Encoding Panic with valid schema and input
> -------------------------------------------------
>
> Key: AVRO-3448
> URL: https://issues.apache.org/jira/browse/AVRO-3448
> Project: Apache Avro
> Issue Type: Bug
> Reporter: Jack Klamer
> Assignee: Jack Klamer
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> After a recent bug regarding Rust Avro's schema ref was fixed to help
> preserve the parsing form of schema
> (https://issues.apache.org/jira/browse/AVRO-3433). This exposed an issue
> where named schemas defined with the rules of the spec (depth first, left to
> right), are not available to the encoding workflow because it indexes schemas
> as it traverses the data. This is a problem for the common use case of
> defining a record within an optional field and it being encoded as Null, and
> not having that type then available during encoding for the next field.Â
> Â
> This was patched for level + 1 schema definitions but was not solved within
> the fullness of the specÂ
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
