[
https://issues.apache.org/jira/browse/AVRO-3459?focusedWorklogId=744538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744538
]
ASF GitHub Bot logged work on AVRO-3459:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/22 00:59
Start Date: 19/Mar/22 00:59
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1607:
URL: https://github.com/apache/avro/pull/1607#issuecomment-1072908174
This seems to be breaking change for some users. The generated code should
not be different by default. If a user does some post processing on the
generated code, this will potentially break them. Maybe a future --nullable
option to avrogen, however I am not sure I see the actual benefit. Beside maybe
the generated code looks more modern, but the compiled code will be pretty much
identical.
Is there any known benefit making those changes in the generated code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744538)
Time Spent: 20m (was: 10m)
> Use simple types and nullable modifier
> --------------------------------------
>
> Key: AVRO-3459
> URL: https://issues.apache.org/jira/browse/AVRO-3459
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> First, it is more common to use the simple types keyword instead of the
> struct type. ie: int instead of System.Int32
> Second, instead of using the struct Nullable<int> you can use int?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
