[
https://issues.apache.org/jira/browse/AVRO-2883?focusedWorklogId=744778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744778
]
ASF GitHub Bot logged work on AVRO-2883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/22 20:56
Start Date: 20/Mar/22 20:56
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1610:
URL: https://github.com/apache/avro/pull/1610#discussion_r830671999
##########
File path: lang/csharp/src/apache/codegen/Avro.codegen.csproj
##########
@@ -55,15 +55,6 @@
<WarningsAsErrors />
</PropertyGroup>
- <!-- See lang/csharp/README.md for tool and library dependency update
strategy -->
- <ItemGroup>
- <PackageReference Include="Newtonsoft.Json"
Version="$(NewtonsoftJsonVersion)" />
- <PackageReference Include="System.CodeDom"
Version="$(SystemCodeDomVersion)" />
- <PackageReference Include="System.Reflection"
Version="$(SystemReflectionVersion)" />
- <PackageReference Include="System.Reflection.Emit.ILGeneration"
Version="$(SystemReflectionEmitILGenerationVersion)" />
- <PackageReference Include="System.Reflection.Emit.Lightweight"
Version="$(SystemReflectionEmitLightweightVersion)" />
- </ItemGroup>
Review comment:
Btw when I do sneaky stuff like this, usually create a specific commit
for it and explain somewaht in the commit mnessage.
https://github.com/apache/avro/pull/1610/commits/6326ee3d262c1e77957c096ba611dabd88c8a8b5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744778)
Time Spent: 1h 10m (was: 1h)
> Avrogen (csharp) namespace mapping missing for references
> ---------------------------------------------------------
>
> Key: AVRO-2883
> URL: https://issues.apache.org/jira/browse/AVRO-2883
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Thomas Vigh Sørensen
> Assignee: Zoltan Csizmadia
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When using *avrogen* for generating C# models from a schemafile, the
> *--namespace* option doesn't behave as expected, if the model refers to other
> types (currently only tested with enums).
> When running
> {code:java}
> avrogen -s file.avsc . --namespace my.avro.ns:my.csharp.ns
> {code}
> the actual namespace of the generated C# files is changed to *my.csharp.ns*,
> but any references between the models are not updated with the correct
> namespace.
>
> Given a schemafile containing:
> {code:json}
> {
> "type" : "record",
> "name" : "TestModel",
> "namespace" : "my.avro.ns",
> "fields" : [ {
> "name" : "eventType",
> "type" : {
> "type" : "enum",
> "name" : "EventType",
> "symbols" : [ "CREATE", "UPDATE", "DELETE" ]
> }
> } ]
> }
> {code}
> And running
> {code:java}
> avrogen -s models.avsc . --namespace my.avro.ns:my.csharp.ns
> {code}
>
> Will produce the following *EventType.cs*
> {code:c#}
> namespace my.csharp.ns
> {
> using System;
> using System.Collections.Generic;
> using System.Text;
> using Avro;
> using Avro.Specific;
>
> public enum EventType
> {
> CREATE,
> UPDATE,
> DELETE,
> }
> }
> {code}
>
> and the following *TestModel.cs*
> {code:c#}
> namespace my.csharp.ns
> {
> using System;
> using System.Collections.Generic;
> using System.Text;
> using Avro;
> using Avro.Specific;
>
> public partial class TestModel : ISpecificRecord
> {
> public static Schema _SCHEMA =
> Avro.Schema.Parse("{\"type\":\"record\",\"name\":\"TestModel\",\"namespace\":\"my.avro.ns\",\"fields\":[{\"name\":\"e"
> +
>
> "ventType\",\"type\":{\"type\":\"enum\",\"name\":\"EventType\",\"namespace\":\"my.avro.ns\",\"sym"
> +
>
> "bols\":[\"CREATE\",\"UPDATE\",\"DELETE\"]}}]}");
> private my.avro.ns.EventType _eventType;
> // More generated code
> }
> }
> {code}
> Notice how the namespace is set correctly to *my.csharp.ns* in both files,
> but the namespace of the referenced *EventType* in *TestModel.cs* is
> incorrect.
>
> Example of expected output (*TestModel.cs*):
> {code:c#}
> namespace my.csharp.ns
> {
> using System;
> using System.Collections.Generic;
> using System.Text;
> using Avro;
> using Avro.Specific;
>
> public partial class TestModel : ISpecificRecord
> {
> public static Schema _SCHEMA =
> Avro.Schema.Parse("{\"type\":\"record\",\"name\":\"TestModel\",\"namespace\":\"my.avro.ns\",\"fields\":[{\"name\":\"e"
> +
>
> "ventType\",\"type\":{\"type\":\"enum\",\"name\":\"EventType\",\"namespace\":\"my.avro.ns\",\"sym"
> +
>
> "bols\":[\"CREATE\",\"UPDATE\",\"DELETE\"]}}]}");
> private my.csharp.ns.EventType _eventType;
> // More generated code
> }
> }
> {code}
>
> Code for reproducing the issue can be found at:
> [https://github.com/FuKe/avrogen-namespace-bug]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
