[
https://issues.apache.org/jira/browse/AVRO-1438?focusedWorklogId=744790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744790
]
ASF GitHub Bot logged work on AVRO-1438:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/22 22:25
Start Date: 20/Mar/22 22:25
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1604:
URL: https://github.com/apache/avro/pull/1604#issuecomment-1073361061
Instaed of implementing the caching at in the RecordScheme.CanRead function:
1. Can the caching be implemented at the level where the CanRead is called?
If the CanRead is called many times, all the other CanRead functions are
affected by this performance gain.
2. Did you investigate what causes the CanRead being called many times? E.g.
as much as I can tell by looking at GenericReader code , IMO the CanRead shoudl
be done in the constructor and not in every Read, is it possible just simply
moving the CanRead check to the constructor will fix this issue without the
caching?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744790)
Time Spent: 1h 10m (was: 1h)
> C# reader performance improvement
> ---------------------------------
>
> Key: AVRO-1438
> URL: https://issues.apache.org/jira/browse/AVRO-1438
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.7.5
> Reporter: David Taylor
> Priority: Minor
> Labels: pull-request-available
> Attachments: RecordSchema.cs.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> GenericReader/SpecificReader spend a lot of time comparing the reader/writer
> schema. Remembering the last good match speeds things up about 15% in my
> tests using the avro.pref project for timings. This does not impact the
> DatumReader implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
