[
https://issues.apache.org/jira/browse/AVRO-3458?focusedWorklogId=745260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745260
]
ASF GitHub Bot logged work on AVRO-3458:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 17:11
Start Date: 21/Mar/22 17:11
Worklog Time Spent: 10m
Work Description: KyleSchoonover removed a comment on pull request #1606:
URL: https://github.com/apache/avro/pull/1606#issuecomment-1074174174
> 1. GenericTests.cs already has many GenerricRecord related tests. Why are
these tests in a seperate GenericRecordTests.cs file?
> 2. Could these tests utilize the mkRecord and other helper code
implemenetd in GenericTests.cs?
> 3. schema definition strings are preferred to be defined as
const/readonly/static fileds or use test case to specify them
1. These are unit tests specific to just GenericRecord.
2. It could, but the tests don't require something that complex
3. Moved the base schema to a const.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 745260)
Time Spent: 50m (was: 40m)
> Add test coverage for GenericRecord
> -----------------------------------
>
> Key: AVRO-3458
> URL: https://issues.apache.org/jira/browse/AVRO-3458
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add additional test coverage for GenericRecord.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
