[
https://issues.apache.org/jira/browse/AVRO-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Csizmadia updated AVRO-3475:
-----------------------------------
Description:
During fixing AVRO-3471, I noticed that negative in/long values or negative
TimeSpan values are allowed for time-millis and time-micros.
[https://avro.apache.org/docs/current/spec.html] states that, it is supposed to
be the number of us/ms after midnight 00:00:00. The following TimSpan values do
not cause any overflow exceptions:
"-00:00:00.001"
"-999999.00:00:00"
# This change should throw exceptions in cases where the code has not thrown
exceptions before
# OutOfRange exception message should be changed to `'time-millis/micros'
value must be at least '00:00:00' and less than '1.00:00:00'.` to reflect the
spec precisely
It might make sense to introduce this change only in 1.12.0, because of all the
above changes
was:
During fixing AVRO-3471, I noticed that negative in/long values or negative
TimeSpan values are allowed for time-millis and time-micros.
[https://avro.apache.org/docs/current/spec.html] states that, it is supposed to
be the number of us/ms after midnight 00:00:00. The following TimSpan values do
not cause any overflow exceptions:
"-00:00:00.001"
"-999999.00:00:00"
This change should throw exceptions in cases where the code has not thrown
exceptions before, so it might make sense to introduce this change only in
1.12.0
> Enforce time-millis and time-micros specification
> -------------------------------------------------
>
> Key: AVRO-3475
> URL: https://issues.apache.org/jira/browse/AVRO-3475
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Fix For: 1.12.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> During fixing AVRO-3471, I noticed that negative in/long values or negative
> TimeSpan values are allowed for time-millis and time-micros.
> [https://avro.apache.org/docs/current/spec.html] states that, it is supposed
> to be the number of us/ms after midnight 00:00:00. The following TimSpan
> values do not cause any overflow exceptions:
>
> "-00:00:00.001"
> "-999999.00:00:00"
>
> # This change should throw exceptions in cases where the code has not thrown
> exceptions before
> # OutOfRange exception message should be changed to `'time-millis/micros'
> value must be at least '00:00:00' and less than '1.00:00:00'.` to reflect the
> spec precisely
>
> It might make sense to introduce this change only in 1.12.0, because of all
> the above changes
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
