[
https://issues.apache.org/jira/browse/AVRO-2211?focusedWorklogId=752066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752066
]
ASF GitHub Bot logged work on AVRO-2211:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/22 21:20
Start Date: 03/Apr/22 21:20
Worklog Time Spent: 10m
Work Description: yanivru commented on code in PR #1597:
URL: https://github.com/apache/avro/pull/1597#discussion_r841278833
##########
lang/csharp/src/apache/main/Schema/MapSchema.cs:
##########
@@ -36,10 +36,11 @@ public class MapSchema : UnnamedSchema
/// Creates a new <see cref="MapSchema"/> from the given schema.
/// </summary>
/// <param name="type">Schema to create the map schema from.</param>
+ /// <param name="cutsomProperties">Dictionary that provides access to
custom properties</param>
/// <returns>A new <see cref="MapSchema"/>.</returns>
- public static MapSchema CreateMap(Schema type)
+ public static MapSchema CreateMap(Schema type, PropertyMap
cutsomProperties = null)
Review Comment:
Fixed
Issue Time Tracking
-------------------
Worklog Id: (was: 752066)
Time Spent: 5h (was: 4h 50m)
> SchemaBuilder equivalent or other means of schema creation
> ----------------------------------------------------------
>
> Key: AVRO-2211
> URL: https://issues.apache.org/jira/browse/AVRO-2211
> Project: Apache Avro
> Issue Type: Wish
> Components: csharp
> Reporter: Dan Stelljes
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Currently, the only way to create a schema is via the Schema.Parse method.
> We'd like to be able to build a schema programmatically—would it be possible
> to (1) introduce an analogue to the SchemaBuilder from the Java library or
> (2) expose constructors on Schema and its descendants?
> Would be more than happy to contribute work on this given some direction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
