[ 
https://issues.apache.org/jira/browse/AVRO-3490?focusedWorklogId=757119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757119
 ]

ASF GitHub Bot logged work on AVRO-3490:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/22 17:29
            Start Date: 14/Apr/22 17:29
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover opened a new pull request, #1644:
URL: https://github.com/apache/avro/pull/1644

   ### Jira
   
   - [ ] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them 
in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3490
    - Parent Issue: https://issues.apache.org/jira/browse/AVRO-3383
   
   ### Tests
   
   - [ ] My PR  does not need testing for this extremely good reason: non 
functional change.  Test should already cover this scenario
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 757119)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix IDE0016 Use throw expression
> --------------------------------
>
>                 Key: AVRO-3490
>                 URL: https://issues.apache.org/jira/browse/AVRO-3490
>             Project: Apache Avro
>          Issue Type: Sub-task
>          Components: csharp
>            Reporter: Kyle Schoonover
>            Priority: Minor
>             Fix For: 1.12.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java}
> // csharp_style_throw_expression = true
> this.s = s ?? throw new ArgumentNullException(nameof(s));
> // csharp_style_throw_expression = false
> if (s == null) { throw new ArgumentNullException(nameof(s)); }
> this.s = s; {code}
> For reference: [IDE0016: Use throw expression - .NET | Microsoft 
> Docs|https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0016]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to