[
https://issues.apache.org/jira/browse/AVRO-3492?focusedWorklogId=757760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757760
]
ASF GitHub Bot logged work on AVRO-3492:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/22 05:28
Start Date: 18/Apr/22 05:28
Worklog Time Spent: 10m
Work Description: martin-g commented on code in PR #1647:
URL: https://github.com/apache/avro/pull/1647#discussion_r851887954
##########
lang/rust/avro_derive/src/lib.rs:
##########
@@ -277,6 +282,15 @@ fn preserve_optional(op: Option<impl quote::ToTokens>) ->
TokenStream {
}
}
+fn preserve_vec(op: Vec<impl quote::ToTokens>) -> TokenStream {
Review Comment:
Just copied your code and adapted! :-)
Issue Time Tracking
-------------------
Worklog Id: (was: 757760)
Time Spent: 1h (was: 50m)
> Rust: Implement derive aliases via annotation
> ---------------------------------------------
>
> Key: AVRO-3492
> URL: https://issues.apache.org/jira/browse/AVRO-3492
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#222222}Follow up on the Avro derive work. {color}
> {color:#222222}We want to be able to set "aliases" for a
> Schema::Record.{color}
> E.g. a slice of strings:
> {code:java}
> #[derive(Debug, Serialize, Deserialize, AvroSchema, Clone, PartialEq)]
> #[avro(aliases = ["a", "b", "c"])]
> struct TestBasicWithU32 {
> a: u32,
> } {code}
> or the less desired comma separated string:
> {code:java}
> #[derive(Debug, Serialize, Deserialize, AvroSchema, Clone, PartialEq)]
> #[avro(aliases = "a, b, c")]
> struct TestBasicWithU32 {
> a: u32,
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)