[ 
https://issues.apache.org/jira/browse/AVRO-3499?focusedWorklogId=759378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759378
 ]

ASF GitHub Bot logged work on AVRO-3499:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Apr/22 16:38
            Start Date: 20/Apr/22 16:38
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover opened a new pull request, #1656:
URL: https://github.com/apache/avro/pull/1656

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them 
in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3499
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: non 
functional changes
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 759378)
    Time Spent: 40m  (was: 0.5h)

> Fix IDE0079 Remove unnecessary suppression
> ------------------------------------------
>
>                 Key: AVRO-3499
>                 URL: https://issues.apache.org/jira/browse/AVRO-3499
>             Project: Apache Avro
>          Issue Type: Sub-task
>          Components: csharp
>            Reporter: Kyle Schoonover
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code:java}
> class C1
> {
>     // Necessary pragma suppression
> #pragma warning disable IDE0051 // IDE0051: Remove unused member
>     private int UnusedMethod() => 0;
> #pragma warning restore IDE0051
>     // IDE0079: Unnecessary pragma suppression
> #pragma warning disable IDE0051 // IDE0051: Remove unused member
>     private int UsedMethod() => 0;
> #pragma warning restore IDE0051
>     public int PublicMethod() => UsedMethod();
> }
> class C2
> {
>     // Necessary SuppressMessage attribute suppression
>     [SuppressMessage("CodeQuality", "IDE0051:Remove unused private members", 
> Justification = "<Pending>")]
>     private int _unusedField;
>     // IDE0079: Unnecessary SuppressMessage attribute suppression
>     [SuppressMessage("CodeQuality", "IDE0051:Remove unused private members", 
> Justification = "<Pending>")]
>     private int _usedField;
>     public int PublicMethod2() => _usedField;
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to