[
https://issues.apache.org/jira/browse/AVRO-3506?focusedWorklogId=765361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765361
]
ASF GitHub Bot logged work on AVRO-3506:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/22 11:06
Start Date: 03/May/22 11:06
Worklog Time Spent: 10m
Work Description: martin-g commented on code in PR #1672:
URL: https://github.com/apache/avro/pull/1672#discussion_r863657333
##########
lang/rust/avro/src/types.rs:
##########
@@ -355,7 +356,11 @@ impl Value {
}
}
- pub(crate) fn validate_internal(&self, schema: &Schema, names: &NamesRef)
-> Option<String> {
+ pub(crate) fn validate_internal<S: std::borrow::Borrow<Schema>>(
Review Comment:
What is the benefit of using `std::borrow::Borrow` here ?
##########
lang/rust/avro/src/schema.rs:
##########
@@ -434,6 +434,86 @@ impl<'s> ResolvedSchema<'s> {
}
}
+pub(crate) struct ResolvedOwnedSchema {
Review Comment:
Can we avoid the code duplication somehow ?
For example by using `ResolvedSchema.clone()` where needed ?
##########
share/test/data/messageV1/README.md:
##########
@@ -0,0 +1,45 @@
+BinaryMessage data in single object encoding
https://avro.apache.org/docs/current/spec.html#single_object_encoding
+
+Ground truth data generated with Java Code
Review Comment:
OK, the `.bin` file will be pre-generated!
But we should run the new example as part of the interop tests, right ?
Issue Time Tracking
-------------------
Worklog Id: (was: 765361)
Time Spent: 1.5h (was: 1h 20m)
> [rust] Implement Single Object Writer
> -------------------------------------
>
> Key: AVRO-3506
> URL: https://issues.apache.org/jira/browse/AVRO-3506
> Project: Apache Avro
> Issue Type: New Feature
> Reporter: Jack Klamer
> Assignee: Jack Klamer
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The spec contains a definition for Single object Encoding:
> https://avro.apache.org/docs/current/spec.html#single_object_encoding
> Rust should have a compatible writer
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
