ashley-taylor opened a new pull request, #1680: URL: https://github.com/apache/avro/pull/1680
To implement this feature, I used a `CustomEncoding`. Added two new methods to pass the `DatumReader`/`DatumWriter`, allowing other `CustomEncoding` to not have to define an entire custom schema but use a hybrid approach. With this, I also change `AvroEncode` to be able to specify at a class level. Feels generically helpful to be able to instrument the class instead of all fields referencing the class. Used reflection to read the `isRecord` method from the `class` class so that it will work on older versions of java. For records, fields can not be modified or accessed with unsafe offsets reads. Instead, the constructor must be invoked, and reads must be done using either method/field reflection. To identify the appropriate constructor, I use the order of the fields. Since it is a record and can not be extended, reading the direct fields from the record class is safe. I have not written tests or updated documentation yet. I am seeking some feedback on the approach first. Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/AVRO-3126) issues ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
