[ 
https://issues.apache.org/jira/browse/AVRO-3126?focusedWorklogId=775314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775314
 ]

ASF GitHub Bot logged work on AVRO-3126:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/22 02:44
            Start Date: 27/May/22 02:44
    Worklog Time Spent: 10m 
      Work Description: ashley-taylor commented on code in PR #1680:
URL: https://github.com/apache/avro/pull/1680#discussion_r883228655


##########
lang/java/build.sh:
##########
@@ -35,6 +35,11 @@ main() {
         # Test the modules that depend on hadoop using Hadoop 2
         mvn -B test -Phadoop2
         ;;
+      testJava17)
+        mvn -DdisableJava17=false -B test
+        # Test the modules that depend on hadoop using Hadoop 2
+        mvn -B test -Phadoop2

Review Comment:
   Happy to make that change. Just want to put rationale before doing that. 
Might change your mind 
   
   With the change to make the module included by default but skip the 
compile/tests.
   
   running `mvn -DdisableJava17=false -B test` will run all the tests in every 
module. Can add more `mvn` args to try and narrow the rerun down to only what 
is needed. But figured in the main test run for java17+ enable the module 
preventing the need to redo all the other work. This way it only adds a few 
seconds to the build. As opposed to redoing the step that takes minutes.
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 775314)
    Time Spent: 1h 40m  (was: 1.5h)

> Create a module to integrate Java 17 specific features (like Java Records) 
> with Avro
> ------------------------------------------------------------------------------------
>
>                 Key: AVRO-3126
>                 URL: https://issues.apache.org/jira/browse/AVRO-3126
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Ismaël Mejía
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Java introduced [records|https://openjdk.java.net/jeps/359] on Java 14. It is 
> a good idea to explore how we can make users life easier using modern Java 
> APIs for example when mapping Java Records from/to Avro Records.
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to