Steven Aerts created AVRO-3527:
----------------------------------

             Summary: Generated equals() and hashCode() for SpecificRecords
                 Key: AVRO-3527
                 URL: https://issues.apache.org/jira/browse/AVRO-3527
             Project: Apache Avro
          Issue Type: Improvement
          Components: java
            Reporter: Steven Aerts
         Attachments: equals_hashcode_after.txt, equals_hashcode_before.txt, 
flame_graph.jpeg

When profiling our production system, we found that it was spending almost 40% 
of its overall time in the {{SpecificRecordBase.hashCode()}} and 
{{SpecificRecordBase.equals()}} implementations.

In some sections of its logic we see that almost all time is spend in those 
function, as can be seen in attached flame graph  (blue "pyramids")

!flame_graph.jpeg|width=385,height=99!

By generating the {{.equals()}} and {{.hashCode()}} all this overhead 
disappeared and this application became 35% faster overall. 
Also on other AVRO heavy applications we saw noticeable performance gains where 
we hadn't expect them due to this improvement.

A generated implementation of {{.hashCode()}} becomes 5 to 10 times faster than 
its generic counterpart. For {{.equals()}} it is 10 to 20 times faster.
Which is also visible in the attached JMH benchmarks.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to