[
https://issues.apache.org/jira/browse/AVRO-3527?focusedWorklogId=779188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779188
]
ASF GitHub Bot logged work on AVRO-3527:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 16:54
Start Date: 07/Jun/22 16:54
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on PR #1708:
URL: https://github.com/apache/avro/pull/1708#issuecomment-1148926792
Thanks for the PR, this looks really interesting! I set the target for
1.12.0 because it's a change in how classes are generated... but I'm curious
whether that should really be the case. I really don't think there's any
reason this could be a major change! What do you think?
Issue Time Tracking
-------------------
Worklog Id: (was: 779188)
Time Spent: 50m (was: 40m)
> Generated equals() and hashCode() for SpecificRecords
> -----------------------------------------------------
>
> Key: AVRO-3527
> URL: https://issues.apache.org/jira/browse/AVRO-3527
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
> Reporter: Steven Aerts
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Attachments: equals_hashcode_after.txt, equals_hashcode_before.txt,
> flame_graph.jpeg
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When profiling our production system, we found that it was spending almost
> 40% of its overall time in the {{SpecificRecordBase.hashCode()}} and
> {{SpecificRecordBase.equals()}} implementations.
> In some sections of its logic we see that almost all time is spend in those
> function, as can be seen in attached flame graph (blue "pyramids")
> !flame_graph.jpeg|width=385,height=99!
> By generating the {{.equals()}} and {{.hashCode()}} all this overhead
> disappeared and this application became 35% faster overall.
> Also on other AVRO heavy applications we saw noticeable performance gains
> where we hadn't expect them due to this improvement.
> A generated implementation of {{.hashCode()}} becomes 5 to 10 times faster
> than its generic counterpart. For {{.equals()}} it is 10 to 20 times faster.
> Which is also visible in the attached JMH benchmarks.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
