[ 
https://issues.apache.org/jira/browse/AVRO-3542?focusedWorklogId=784092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784092
 ]

ASF GitHub Bot logged work on AVRO-3542:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jun/22 09:05
            Start Date: 23/Jun/22 09:05
    Worklog Time Spent: 10m 
      Work Description: izveigor opened a new pull request, #1730:
URL: https://github.com/apache/avro/pull/1730

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them 
in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 784092)
    Remaining Estimate: 0h
            Time Spent: 10m

> Scale optimization
> ------------------
>
>                 Key: AVRO-3542
>                 URL: https://issues.apache.org/jira/browse/AVRO-3542
>             Project: Apache Avro
>          Issue Type: Improvement
>    Affects Versions: 1.11.0
>            Reporter: Igor Izvekov
>            Priority: Minor
>             Fix For: 1.12.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changed string in function 
> make_avsc_object (schema.py):
> scale = 0 if json_data.get("scale") is None else json_data.get("scale") -> 
> scale = json_data.get("scale", 0)
>  
> By Python documentation:
> get(self, key, default=None, /)
>     Return the value for key if key is in the dictionary, else default.
>  
> It is more effective and readable than previous.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to