[ 
https://issues.apache.org/jira/browse/AVRO-3520?focusedWorklogId=787780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-787780
 ]

ASF GitHub Bot logged work on AVRO-3520:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jul/22 10:13
            Start Date: 05/Jul/22 10:13
    Worklog Time Spent: 10m 
      Work Description: KalleOlaviNiemitalo commented on code in PR #1692:
URL: https://github.com/apache/avro/pull/1692#discussion_r913627123


##########
lang/java/avro/src/main/java/org/apache/avro/reflect/CustomEncoderFieldAccess.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.avro.reflect;
+
+import org.apache.avro.Schema;
+
+public interface CustomEncoderFieldAccess {

Review Comment:
   Please add javadoc to both FieldAccessor and CustomEncoderFieldAccess, 
saying that classes that extend FieldAccessor can optionally implement 
CustomEncoderFieldAccess.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 787780)
    Time Spent: 40m  (was: 0.5h)

> CustomEncoding doesn't expose the read schema
> ---------------------------------------------
>
>                 Key: AVRO-3520
>                 URL: https://issues.apache.org/jira/browse/AVRO-3520
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.11.0
>            Reporter: Colin
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: patchTest.txt
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently it is not possible to detect a schema change when using 
> `CustomEncoding<T>`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to