[ 
https://issues.apache.org/jira/browse/AVRO-3219?focusedWorklogId=788212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788212
 ]

ASF GitHub Bot logged work on AVRO-3219:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jul/22 12:39
            Start Date: 06/Jul/22 12:39
    Worklog Time Spent: 10m 
      Work Description: RobertIndie commented on code in PR #1348:
URL: https://github.com/apache/avro/pull/1348#discussion_r914788796


##########
lang/csharp/src/apache/main/Reflect/ClassCache.cs:
##########
@@ -269,18 +269,12 @@ public void LoadClassCache(Type objType, Schema s)
                                 LoadClassCache(objType, o);
                             }
 
-                            if (objType.IsGenericType)
+                            var innerType = 
Nullable.GetUnderlyingType(objType);
+                            if (innerType != null)

Review Comment:
   Oh sorry. My mistake.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 788212)
    Time Spent: 2h  (was: 1h 50m)

> Not support for nullable enum type fields
> -----------------------------------------
>
>                 Key: AVRO-3219
>                 URL: https://issues.apache.org/jira/browse/AVRO-3219
>             Project: Apache Avro
>          Issue Type: New Feature
>          Components: csharp
>    Affects Versions: 1.10.2
>            Reporter: Zike Yang
>            Assignee: Zike Yang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.1
>
>         Attachments: AVRO-3219.patch
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently, when the schema contain nullable enum type, it will throw 
> Exception`Couldnot find enumeration for avro full name ...` while writing or 
> reading.
>  
> We need to add support for the nullable enum type.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to