Diptonil opened a new pull request, #1756:
URL: https://github.com/apache/avro/pull/1756

   The changes made are:
   
   - Code altered according to PEP 8 conventions. Files changed are: io.py, 
constants.py, schema.py, codecs.py, datafile.py and compatibility.py.
   - General constants INT_MIN_VALUE, INT_MAX_VALUE, LONG_MIN_VALUE & 
LONG_MAX_VALUE shifted from schema.py to constants.py for clarity and better 
organization.
   
   _(This is my first attempt to contribute to any open source project, not 
only this project. If I have made any errors or have misunderstood any step, 
please forgive me. I would be happy to adhere to any suggestions)_
   
   ### Jira
   
   - [x] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO-3571) issues and references 
them in the PR title. For example, "[AVRO-3571]: Python code refactor and 
rearrangement"
     - https://issues.apache.org/jira/browse/AVRO-3571
     - No dependencies are being added.
   
   ### Tests
   
   - [x] My PR does not need testing because I have only moved certain 
constants from schema.py to constants.py and have refactored code to better 
adhere to the PEP 8 style guide.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] My commit doesn't add any functionality whatsoever.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to