[
https://issues.apache.org/jira/browse/AVRO-3573?focusedWorklogId=790308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790308
]
ASF GitHub Bot logged work on AVRO-3573:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/22 07:49
Start Date: 13/Jul/22 07:49
Worklog Time Spent: 10m
Work Description: clesaec commented on code in PR #1759:
URL: https://github.com/apache/avro/pull/1759#discussion_r919760019
##########
lang/py/avro/schema.py:
##########
@@ -570,7 +570,12 @@ def __init__(
raise avro.errors.InvalidName("An enum symbol must be a
valid schema name.")
if len(set(symbols)) < len(symbols):
- raise avro.errors.AvroException(f"Duplicate symbol: {symbols}")
+ duplicate_symbols = {symbol for symbol in symbols if
symbols.count(symbol) > 1}
+
+ if len(duplicate_symbols) == 1:
Review Comment:
What if there are 2 duplicate symbols ["A", "A", "B", "B"]
shouldn't it be :
`if len(duplicate_symbols) > 0:`
Issue Time Tracking
-------------------
Worklog Id: (was: 790308)
Time Spent: 40m (was: 0.5h)
> Duplicate symbols (EnumSchema)
> ------------------------------
>
> Key: AVRO-3573
> URL: https://issues.apache.org/jira/browse/AVRO-3573
> Project: Apache Avro
> Issue Type: Improvement
> Affects Versions: 1.11.0
> Reporter: Igor Izvekov
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If EnumSchema has duplicate symbols, an error will raise. Instead of a list
> of duplicate symbols or a value of duplicate symbol, error shows all list of
> symbols. Improvement removes this defect and shows a message "Duplicate
> symbol" with the symbol, if it is one, or "Duplicates symbols" with the list
> of duplicate symbols, if there are more than one symbol.
> P.S. Tests do not check error's message. Try to write a test for checking a
> message of an error can take a long time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
