[
https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=800495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800495
]
ASF GitHub Bot logged work on AVRO-3601:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/22 06:52
Start Date: 15/Aug/22 06:52
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on code in PR #1826:
URL: https://github.com/apache/avro/pull/1826#discussion_r945464410
##########
lang/c++/test/unittest.cc:
##########
@@ -452,7 +457,14 @@ struct TestSchema {
customAttributes);
std::string expectedJsonWithCustomAttribute =
"{\"type\": \"record\", \"name\": \"Test\",\"fields\": "
- "[{\"name\": \"f1\", \"type\": \"long\",\"extra field\": \"1\"}]}";
+ "[{\"name\": \"f1\", \"type\": \"long\", "
+ "\"arrayField\": \"[1]\", "
+ "\"booleanField\": \"true\", "
+ "\"mapField\": \"{\\\"key1\\\":\\\"value1\\\",
\\\"key2\\\":\\\"value2\\\"}\", "
+ "\"nullField\": \"null\", "
+ "\"numberField\": \"1.23\", "
+ "\"stringField\": \"\\\"field value with \\\"double quotes\\\"\\\"\""
Review Comment:
I think, minimally, the library should be able to read a schema that
contains custom attributes with arbitrary value types, but not necessarily able
to preserve the values in memory and write them out again. That would help
compatibility with future versions of Avro, e.g. new standard logical types.
If CustomAttributes::attributes returns a reference to a map that contains
the string values, then that makes it harder for a future version of the
library to add support for other types without a breaking change.
Issue Time Tracking
-------------------
Worklog Id: (was: 800495)
Time Spent: 4h 40m (was: 4.5h)
> C++ API header contains breaking include
> ----------------------------------------
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
> Issue Type: Bug
> Reporter: Mike Ruffing
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Problem file/line:
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
> * Download AVRO version 1.11.1
> * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
> * Navigate to the installed {{include}} directory
> * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
