[
https://issues.apache.org/jira/browse/AVRO-3609?focusedWorklogId=800975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800975
]
ASF GitHub Bot logged work on AVRO-3609:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/22 14:11
Start Date: 16/Aug/22 14:11
Worklog Time Spent: 10m
Work Description: untereiner commented on PR #1829:
URL: https://github.com/apache/avro/pull/1829#issuecomment-1216692672
I am a rust beginner so I can not comment the code but for what I know it
seems good.
I find it very good to output serde_json::Value types instead of strings
like in the c++ version.
> Do we want to support serializing the custom attributes?
this is what is ambiguous in the spec for me.
I understand this:
> where typeName is either a primitive or derived type name, as defined
below. Attributes not defined in this document are permitted as metadata, but
must not affect the format of serialized data
as not serializing to not modify the format of serialized data
Issue Time Tracking
-------------------
Worklog Id: (was: 800975)
Time Spent: 0.5h (was: 20m)
> support custom attributes
> -------------------------
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: lionel untereiner
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification :
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field
> level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
