[ 
https://issues.apache.org/jira/browse/AVRO-3001?focusedWorklogId=803458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803458
 ]

ASF GitHub Bot logged work on AVRO-3001:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/22 06:40
            Start Date: 25/Aug/22 06:40
    Worklog Time Spent: 10m 
      Work Description: KalleOlaviNiemitalo commented on code in PR #1833:
URL: https://github.com/apache/avro/pull/1833#discussion_r954557727


##########
lang/csharp/src/apache/main/IO/Encoder.cs:
##########
@@ -187,5 +187,10 @@ public interface Encoder
         /// <param name="start">Position within data where the contents 
start.</param>
         /// <param name="len">Number of bytes to write.</param>
         void WriteFixed(byte[] data, int start, int len);
+
+        /// <summary>
+        /// Flushes the encoder.
+        /// </summary>
+        void Flush();

Review Comment:
   Adding a method to a public interface is a breaking change. It is OK for 
this pull request to master (upcoming 1.12.0) but I think these changes should 
not be backported to branch-1.11.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 803458)
    Time Spent: 5h 40m  (was: 5.5h)

> JsonEncode Decode support for C#
> --------------------------------
>
>                 Key: AVRO-3001
>                 URL: https://issues.apache.org/jira/browse/AVRO-3001
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.10.0, 1.11.0
>            Reporter: Krishnan Unni
>            Assignee: Robert Yokota
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> The C# library for avro currently supports only the Binary encoding and also 
> with compile time types (Generic support only). As part of a project I am 
> doing I need to validate the avro schema against the incoming json data on 
> the fly without a predefined type (generated class). So basically comparing 
> an avro schema (string/json representation) against a raw json string. It is 
> possible with the Java library since it supports both non generic types and 
> streams as well as json encoding. With C# currently this is not possible. Is 
> there a plan to extend the C# library to provide these features? If yes, is 
> there a timeline? If not is there any alternative to achieve this? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to