[
https://issues.apache.org/jira/browse/AVRO-3621?focusedWorklogId=803941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803941
]
ASF GitHub Bot logged work on AVRO-3621:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/22 12:11
Start Date: 26/Aug/22 12:11
Worklog Time Spent: 10m
Work Description: shaeqahmed commented on PR #1839:
URL: https://github.com/apache/avro/pull/1839#issuecomment-1228412617
> Awesome!
>
> I've made a small improvement to the panic message for
`assert_not_logged()` because with `assert_ne!()` it was a bit confusing: `left
!= right. Left: X, Right: X`
>
> Waiting for the CI to pass and I will merge it!
Clarifying the message sounds good to me, but hm from what I understood the
thread local LOG_MESSAGES is shared between multiple test cases sequentially,
and only cleared at the end so merely checking for the presence of a
`_last_log` without comparing it to the unexpected value wouldn't be correct
right? I've updated with what I think should be the correct behavior:
```Rust
match LOG_MESSAGES.borrow().last() {
Some(last_log) if last_log == unexpected_message => panic!(
"The following log message should not have been logged: '{}'",
unexpected_message
),
_ => (),
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 803941)
Time Spent: 40m (was: 0.5h)
> [Rust] Improved resolution of nullable record fields
> ----------------------------------------------------
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Shaeq Ahmed
> Assignee: Shaeq Ahmed
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently a nested record cannot be resolved to a corresponding schema where
> the fields are stored as nullable variants. This PR adds support for
> upcasting the values to a Union type to allow for this. This should improve
> support for reading and writing from compatible schemas, where some fields
> are listed as nullable in the destination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
