[ https://issues.apache.org/jira/browse/AVRO-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599120#comment-17599120 ]
ASF subversion and git services commented on AVRO-3597: ------------------------------------------------------- Commit 6aed213831b8d67cd74c8b40497e97a11b113768 in avro's branch refs/heads/branch-1.11 from clesaec [ https://gitbox.apache.org/repos/asf?p=avro.git;h=6aed21383 ] AVRO-3597: Allow custom readers to override string creation (#1847) * AVRO-3597: recall method newInstanceFromString for backward compatibility * AVRO-3597: add licence > Recent changes in GenericDatumReader.java break compatibility > ------------------------------------------------------------- > > Key: AVRO-3597 > URL: https://issues.apache.org/jira/browse/AVRO-3597 > Project: Apache Avro > Issue Type: Bug > Components: java > Affects Versions: 1.11.1 > Reporter: Viktor Dvoretskii > Assignee: Christophe Le Saec > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > We use a custom SpecificDatumReader which overrides the string creation > logic. It looks like this: > {code:java} > class CustomSpecificDatumReader<T> extends SpecificDatumReader<T> { > @Override > protected Object newInstanceFromString(Class c, String s) { > // custom logic > } > } {code} > With [this > commit|https://github.com/apache/avro/commit/820ed6e5ea4417b5735078bfd26c99f1305ea363], > the newInstanceFromString() method is no longer called. Instead, strings are > created with the hard-coded logic within GenericDatumReader.ReaderCache. > It would be appreciated if you made it possible to override the string > creation logic used by GenericDatumReader.ReaderCache. Preferably make use of > the newInstanceFromString() method again to maintain backward compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010)