[
https://issues.apache.org/jira/browse/AVRO-3597?focusedWorklogId=805627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805627
]
ASF GitHub Bot logged work on AVRO-3597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/22 19:16
Start Date: 01/Sep/22 19:16
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on PR #1847:
URL: https://github.com/apache/avro/pull/1847#issuecomment-1234682831
Cherry-picked to
[branch-1.11|https://github.com/apache/avro/commit/6aed213831b8d67cd74c8b40497e97a11b113768].
Issue Time Tracking
-------------------
Worklog Id: (was: 805627)
Time Spent: 20m (was: 10m)
> Recent changes in GenericDatumReader.java break compatibility
> -------------------------------------------------------------
>
> Key: AVRO-3597
> URL: https://issues.apache.org/jira/browse/AVRO-3597
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.11.1
> Reporter: Viktor Dvoretskii
> Assignee: Christophe Le Saec
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We use a custom SpecificDatumReader which overrides the string creation
> logic. It looks like this:
> {code:java}
> class CustomSpecificDatumReader<T> extends SpecificDatumReader<T> {
> @Override
> protected Object newInstanceFromString(Class c, String s) {
> // custom logic
> }
> } {code}
> With [this
> commit|https://github.com/apache/avro/commit/820ed6e5ea4417b5735078bfd26c99f1305ea363],
> the newInstanceFromString() method is no longer called. Instead, strings are
> created with the hard-coded logic within GenericDatumReader.ReaderCache.
> It would be appreciated if you made it possible to override the string
> creation logic used by GenericDatumReader.ReaderCache. Preferably make use of
> the newInstanceFromString() method again to maintain backward compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
