Hi Andrew! Please send the PR! The C++ module is not actively developed at the moment and I'm afraid no one from the Avro committers will take a look at it any time soon. Hopefully other users will review and approve your PR and then me or someone else who is not familiar with the C++ code will merge it.
Martin On Mon, Dec 19, 2022 at 1:16 AM Andrew Marlow <[email protected]> wrote: > Hello everyone, > > I have raised a JIRA, https://issues.apache.org/jira/browse/AVRO-3693 > which > is a minor improvement to avrogencpp. Once the ticket gets approved, > assigned or whatever I intend to create a PR. I have my change in a fork, > waiting in the wings as it were. My question is, am I required to ensure my > change is purely for the issue on the ticket? I took the opportunity to > make a minor correction to the header guard (avoiding double underscore > followed by uppercase letter, which is reserved for use by compiler > implementors). I also included a comment directly after the copyright > comment, which is a warning that the file has been produced by the > avrogencpp code generator and thus should not be edited. These changes are > not to do with 3693. I just found them small and trivial enough to make > while I was there. Will I be expected to raise separate tickets for those > things? Will I be expected to raise 2 tickets, one for the generated > warning and another for the include guard? I don't mind, I just need to > know please. > > -- > Regards, > > Andrew Marlow > http://www.andrewpetermarlow.co.uk >
