CamilAbraham opened a new pull request, #2439:
URL: https://github.com/apache/avro/pull/2439
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you
want to help us improve Avro. To help the community review your contribution in
the best possible way, please go through the checklist below, which will get
the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the
pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers
faster: either the language ("java", "python") or subsystem such as "build" or
"doc" are good candidates.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the
entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just
the [language-specific
SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Every commit message references Jira issues in their subject lines. In
addition, commits follow the guidelines from [How to write a good git commit
message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue
reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
The aim of this pull request is to improve memory usage when reading Avro
encoded files. Fixing AVRO-3802.
This issue was detected when using Apache.Avro C# library for compression
and decompression of large Avro files. Each file is 2-3MB and decompression of
20 files is using 2.1GB memory and memory keep increasing around 200-300MB for
follow up calls.
Attached are images taken of memory profiler of three calls before fix. Each
call decompress the same 20 files. First call uses 2.1GB, increase to 2.37GB
and then 2.68GB.
Call tree is showing most of the memory are used by `DeflatCodec.CopyTo`
method.
- `CopyTo` method is not using Array pool. Default Microsoft's stream
`copyTo` method is much more efficient.
- `inStream` and `outStream` memory streams are not in using statement.
- On `outstream` object creation, object can be initialized with defined
length/stream capacity.
## Verifying this change
Added test that validates that memory usage after reading records from file
reader returns to its initial value. Proving that the reader object is disposed
correctly.
## Documentation
No new features added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
