masongup-mdsol opened a new pull request, #190: URL: https://github.com/apache/avro-rs/pull/190
Addresses #164 I didn't get any response when I asked about preferred designs, so I went ahead and created one that seemed reasonable to me. I created a new Header module with a HeaderBuilder trait, then reimplemented the existing Rabin fingerprint header as a struct impling this trait, and also another one with the Glue schema header type that I used. This design should be sufficiently generic to allow for the future implementation of more header types. I also added a new method to the GenericSingleObjectReader and GenericSingleObjectWriter to allow the creation of each object type with a HeaderBuilder instance. I then modified the existing creator methods to keep the same signature but call these new methods with the RabinFingerprintHeader struct to maintain the current behavior, and I added a couple of new tests to exercise the functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
