PookieBuns opened a new pull request, #458: URL: https://github.com/apache/avro-rs/pull/458
Fixes `The Rust Representation Conundrum` as mentioned in #449 and tested using the provided test suite in the mentioned issue. I considered using enum variant name as lookup method for serializing, shown [here](https://github.com/PookieBuns/avro-rs/commit/74172ecf3916ec1c82a5dcbca2c8caa0f8c943a7), but given the current state in which `Value` doesn't hold the name for named types, I realized it's not possible to do the same for deserialization until further work to support names in `Value` has been done. Therefore, this implementation makes the assumption that if you are using `Option<T>` to represent a nullable union, that means that the `null` is the first variant in the union and serialization / deserialization just bump / decrement the index lookup respectively. I believe this doesn't actually produce any breaking changes, because the status quo is that tagged "Rusty" representations straight up don't work. Please let me know if you have any questions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
