wgtmac opened a new pull request, #3815:
URL: https://github.com/apache/avro/pull/3815

   ## What is the purpose of the change
   
   The fix avoids referring directly to `std::format_context` in the 
`std::formatter` specializations.
   
   With libc++ 21, `<format>` may expose `std::formatter` before the 
`std::format_context` alias is visible in this include chain. That made headers 
like `Types.hh` fail to compile with:
   
   ```text
   missing '#include <__format/format_context.h>'; 'format_context' must be 
declared before it is used
   ```
   
   Instead of depending on libc++’s internal header, the formatter `format` 
methods now take a templated context:
   
   ```cpp
   template<typename FormatContext>
   auto format(avro::Type t, FormatContext &ctx) const
   ```
   
   This is the standard formatter pattern: the library supplies the concrete 
formatting context, and the code no longer needs `std::format_context` to be 
named at header parse time.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to