Ryan Skraba created AVRO-4326:
---------------------------------

             Summary: [Java] Ensure tests don't change the default global 
fastread behaviour
                 Key: AVRO-4326
                 URL: https://issues.apache.org/jira/browse/AVRO-4326
             Project: Apache Avro
          Issue Type: Bug
            Reporter: Ryan Skraba


Using the invoker, we run the java tests twice, once with 
{{org.apache.avro.fastread}}  set to true and once with it set to false.

Some tests explicitly change this setting via 
{{{}GenericData.setFastReaderEnabled(){}}}, which is fine if they are using a 
new instance of SpecificData or GenericData.  If they change the singleton 
instance that tests use by default, it might affect other tests inadvertently.

[https://github.com/apache/avro/pull/3924] fixed one example where the fast 
reader was changed on the global singleton, but we should find a strategy to 
make sure tests that use setFastReaderEnabled only affect their isolated 
instances.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to