kojiromike opened a new pull request, #4079: URL: https://github.com/apache/avro/pull/4079
## What is the purpose of the change This fixes the two AVRO-3803 bugs still on main. It supersedes #2319 by @asosnovsky, which found them. The bytes-compare fix from #2319 already landed via #3710 and its except-clause fix is also already on main. The #2319 pull request has conflicts and no pushes since July 2023. Its `respond()` rewrite drops the `remote_protocol` `None` check. This breaks the first-contact handshake (match NONE). This change fixes the two remaining bugs: * `Responder.respond()` lost errors raised after the handshake. The requestor saw `InvalidAvroBinaryEncoding` instead of the server's error. * Types nested in an "error" schema lost its namespace. ## Verifying this change Added tests cover the following scenarios: * A loopback round trip including the first handshake. * A system error reaching the requestor. * A `FramedReader` empty reader from #2319. * The error namespace. The two bug tests fail on main without the fix. The full lang/py suite, ruff, and mypy pass locally. ## Documentation This introduces no new feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
